B4_Crop Plant Date

B4_Crop Plant Date

This page is a main, parent documentation page for this feature. The tables below provide links to all related documentation on this feature. 

The first Dependencies Table provides information on features dependencies, lists expected Pull Request (PR) date (expected time this feature will be ready for integration), it also lists all the other known new code features that are blocking completion of this code. It lists all known features that depend on this feature being integrated. It also provides the date the PR was actually issued, the name of the integrator, the date the code was integrated and a hash/tag of the code integration into the ACME git repository. The information from this table feeds the overview table in the New Features Dependencies Overview page which is meant to be used by integrators to check the priority order in which the features should be integrated. It also provides an overview of all the new features and the expected integration dates. 

The second Checklist Table lists the code review steps to be taken in order. As you work on integrating your feature into ACME code, step along the Checklist table on your main page, obtain the approvals before going to the next step. For the phase 1 review, the Group Leads are the approvers, they can decide to sign on on the documentation or a verification step even if it is not completely finished, especially for the grandfathered features. The relevant documentation page does have to be created though and the explanation needs to be provided in Summary section as to why it is approved, what is the basis for approval. For example is there were tests performed on related feature and they proved indirectly that this feature works as expected, then the approver needs to document that. 

The Design Document page provides a description of the algorithms, implementation and planned testing including unit, verification, validation and performance testing. 

The Verification and Unit Testing page provides the short information and links to the tests that were performed, together with the links to the runs, their provenance and their results. The same information is called for in The Performance Assessment page and The Validation page in phase 1 of code review process. 

Dependencies Table for this feature

1.Design Doc

Crop Plant Date

2.Owner

@Beth Drewniak

3.PR Ready

Jun 13, 2019 

4.Blocked By#

5.Affects #

PR Approved By

@Katherine Calvin

Date Approved

Jul 16, 2019 

6.Issued PR

https://github.com/E3SM-Project/E3SM/pull/2999

7.PR Assignee

@Junqi Yin (Unlicensed)

8.Integrated

Jul 16, 2019 

9.Hash/Tag

e14128d

10.Git Branch

bbye/lnd/add_crop_planting_date

 

 

Checklist for the Code Review Process for this feature

Action Required

Assignee - Task Owner

Link

Done ?

Done Date

Approved?

Approver

Approved Date

Notes

Action Required

Assignee - Task Owner

Link

Done ?

Done Date

Approved?

Approver

Approved Date

Notes

Phase 1 - Component Level Development and Testing

Design Document

@Beth Drewniak

B4_Crop Plant Date Design Document

Jun 13, 2019  

@Katherine Calvin

Jun 18, 2019 

I would suggest adding a test for tropical crops

Verification and Unit Tests

B4 Crop Plant Date Verification Phase 1

 

 

 

Performance Assessment

B4 Crop Plant Date Performance Phase 1

 

 

 

Validation Tests

B4 Crop Plant Date Validation Phase 1

 

 

 

Issue Pull Request

@Gautam Bisht

PR-2999

Jun 18, 2019

@Gautam Bisht

Jun 19, 2019

 

PR Integrator

@Gautam Bisht

-

 

integrated date

-

-

-

-

Phase 2 - Coupled System Integration and Testing

Phase 2 Process Doc

 

 

Feature's Coupled Performance

 

 

 

Feature's Coupled Validation

 

 

 

Final Approval to part of ACME model

 

-

-

-

-