W5 Two-way Coupled Irrigation

W5 Two-way Coupled Irrigation

This page is a main, parent documentation page for this feature. The tables below provide links to all related documentation on this feature. 

The first Dependencies Table provides information on features dependencies, lists expected Pull Request (PR) date (expected time this feature will be ready for integration), it also lists all the other known new code features that are blocking completion of this code. It lists all known features that depend on this feature being integrated. It also provides the date the PR was actually issued, the name of the integrator, the date the code was integrated and a hash/tag of the code integration into the ACME git repository. The information from this table feeds the overview table in the New Features Dependencies Overview page which is meant to be used by integrators to check the priority order in which the features should be integrated. It also provides an overview of all the new features and the expected integration dates. 

The second Checklist Table lists the code review steps to be taken in order. As you work on integrating your feature into ACME code, step along the Checklist table on your main page, obtain the approvals before going to the next step. For the phase 1 review, the Group Leads are the approvers, they can decide to sign on on the documentation or a verification step even if it is not completely finished, especially for the grandfathered features. The relevant documentation page does have to be created though and the explanation needs to be provided in Summary section as to why it is approved, what is the basis for approval. For example is there were tests performed on related feature and they proved indirectly that this feature works as expected, then the approver needs to document that. 

The Design Document page provides a description of the algorithms, implementation and planned testing including unit, verification, validation and performance testing. 

The Verification and Unit Testing page provides the short information and links to the tests that were performed, together with the links to the runs, their provenance and their results. The same information is called for in The Performance Assessment page and The Validation page in phase 1 of code review process. 

Dependencies Table for this feature

1.Design Doc

Two-way coupled irrigation

2.Owner

@Tian Zhou

3.PR Ready

Jul 17, 2019 

4.Blocked By#

5.Affects #

PR Approved By

@Chris Golaz

Date Approved

Jul 25, 2019 

6.Issued PR

https://github.com/E3SM-Project/E3SM/pull/3074

7.PR Assignee

@Gautam Bisht

8.Integrated

9.Hash/Tag

10.Git Branch

tizhou/two-way-irrigation

 

 

Checklist for the Code Review Process for this feature

Action Required

Assignee - Task Owner

Link

Done ?

Done Date

Approved?

Approver

Approved Date

Notes

Phase 1 - Component Level Development and Testing

Design Document

@Tian Zhou

W5 Two-way Coupled Irrigation Design Document

 

Verification and Unit Tests

@Tian Zhou

W5 Two-way Coupled Irrigation Verification Phase 1

 

Jul 12, 2019 

 

 

 

Performance Assessment

@Tian Zhou

W5 Two-way Coupled Irrigation Performance Phase 1

Jul 12, 2019 

 

 

 

Validation Tests

@Tian Zhou

W5 Two-way Coupled Irrigation Validation Phase 1

 

 

 

Issue Pull Request

@Tian Zhou

#3074

Jul 16, 2019 

 

 

 

PR Integrator

assigned integrator

-

 

integrated date

-

-

-

-

Phase 2 - Coupled System Integration and Testing

Phase 2 Process Doc

 

 

Feature's Coupled Performance

 

 

 

Feature's Coupled Validation

 

 

 

Final Approval to part of ACME model

 

-

-

-

-